Skip to content

Use bitset instead of array of bool for ChannelBitArray #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use bitset instead of array of bool for ChannelBitArray #17

wants to merge 1 commit into from

Conversation

@saxbophone
Copy link
Owner

@saxbophone saxbophone commented May 9, 2020

I tried to use std::bitset in the scrambling lookup table constructor too but alas, not all of its operators are constexpr-safe. It's a shame as it would produce far more readable code for the bit-masking parts of that algorithm, however having it generated at compile-time is more important and the code's fairly readable as-is, and well-commented.

@saxbophone
Copy link
Owner Author

saxbophone commented May 9, 2020

Pros:

  • Possibly more memory-efficient
  • Provides for an easy way to build up these arrays of bits (from the stream of channel-bits)

Cons:

  • Ties the interface of this particular part of code to a future implementation detail that's outside this part of the code.

Putting this on hold until the code that converts a ChannelFrame into a sequence of 588 Channel Bits.

@saxbophone saxbophone added the blocked Something that can't progress due to a prerequisite not being met label May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

blocked Something that can't progress due to a prerequisite not being met

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saxbophone